Hamish Moffatt

> @hmoffatt ,Please run command "./vcpkg x-add-version argon2 --overwrite-version" and commit again done, I was waiting until I had fixed the cmake integration before updating that again.

Thanks for the reviews, I've learned a lot. I hope this fixes all the issues that come up in review. I've tested with a simple cmake project to use the...

> Ping @hmoffatt for response Thanks for the feedback, I will make changes in the next day or two

> @hmoffatt ,Thanks for your reply, Could you reply for @JackBoosY's request change? I think I have responded to all the requests, did I miss any?

> @hmoffatt Please see my request changes before, some of them are unresolved. Thanks I had forgotten to mark these as resolved.

Are any further changes required?

> @hmoffatt, Can you reply to this [review ](https://github.com/microsoft/vcpkg/pull/24747#discussion_r908077200)from @JackBoosY? Thank you for the ping. Unless I missed something I have already replied and don't have any more news to...

> Request changes: > > * [[Argon2] Add new port #24747 (comment)](https://github.com/microsoft/vcpkg/pull/24747#discussion_r894335483) > > * [[Argon2] Add new port #24747 (comment)](https://github.com/microsoft/vcpkg/pull/24747#discussion_r894338599) > > * [[Argon2] Add new port #24747 (comment)](https://github.com/microsoft/vcpkg/pull/24747#discussion_r894339804)...

Sorry I have only just realized that my review replies were not submitted and hence you could not see them @JackBoosY @autoantwort @JonLiu1993

> Can you link to them somewhere? We generally want to avoid 'putting words in upstream's mouth' and/or otherwise doing things of which they are unaware. The visibility patch is...