Harry Mellor comments

Results 298 comments of


                                            Harry Mellor

[Chore] Ignore Ruff warning on E501

Ruff format is a drop in replacement for Black. It implements all the same rules. So yeah we'd use Ruff format.

[Chore] Ignore Ruff warning on E501

I believe we'd have to roll out Black in stages so we don't disrupt everyone's PRs too much. Similarly to how the removal of deprecating type hints has been gradually...

[Chore] Ignore Ruff warning on E501

We probably shouldn't globally disable line length limits tbf. I'll start thinking about porting from yapf to ruff format and make some separate PRs.

[Chore] Ignore Ruff warning on E501

Ok, let's leave this for now them. Hopefullt it'll get better with a switch to Black

[Core] Allow vLLM to stream n tokens at a time

Closing as duplicate

[Model] Activated LoRA

@tdoublep do we have some evidence that a-lora is gaining popularity?

[Model] Activated LoRA

Thanks for the context @kgreenewald, I agree @lastras that this is a positive signal for getting this PR merged. @tdoublep will you have time to update this PR?

[Model] Activated LoRA

I've pinged @jeejeelee for a review if they have time

[Bug]: Cannot pull the docker image for installation

Is the issue that your Docker setup cannot pull the https://github.com/vllm-project/vllm/blob/238dfc8ac3f9befb594e1ad2f249616afc68d484/Dockerfile#L11 when builing the Dockerfile?

[Bug]: When using the method, it was found that for Chinese, when processing a batch of data, there are always some data that cannot be recognized at all, or the recognized content is completely incorrect.

Please use ``` for code blocks so they are formatted correctly, making the issue more readable