vllm
vllm copied to clipboard
vllm-project
[Chore] Ignore Ruff warning on E501
This PR disable E501 checks for line too long. This warning is annoying when writing logs and we should just let yapf handle breakpoint if needed to
Signed-off-by: Aaron Pham [email protected]
👋 Hi! Thank you for contributing to the vLLM project.
💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.
Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.
To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.
🚀
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Eventually I hope to switch from yapf to black (run with ruff), which has a line length of 88. Generally increasing line length is a one way move so I'd be cautious of increasing it so much.
Do we want to use black? or ruff format are sufficient enough?
afaict ruff format should introduce least amount of change, given that it will still respect some of the yapf-formatted code
Ruff format is a drop in replacement for Black. It implements all the same rules.
So yeah we'd use Ruff format.
I believe we'd have to roll out Black in stages so we don't disrupt everyone's PRs too much. Similarly to how the removal of deprecating type hints has been gradually rolled out
But at a certain point where we touch model_executor or v1, it is bound to disrupt everyone PR right?
fwiw I think we can add the config and run this before releasing the next version
We probably shouldn't globally disable line length limits tbf. I'll start thinking about porting from yapf to ruff format and make some separate PRs.
I'm ok with manually adding noqa E501, just that it will contain a lot of these
Ok, let's leave this for now them. Hopefullt it'll get better with a switch to Black