Henry Lin

Results 9 comments of Henry Lin

You cannot put RGB code into the constructor parameters, but you can use the ToColor extension to change the Primary.Lime500 to Color.

At which line did you get the error?

> There still seems to be issues with sliders not staying within bounds That seems to be an issue introduced in slider rotation PR (#17591), which means it affects the...

Thanks for the suggestions. I've done a lot of playtesting since then and I agree with most of your points. But instead of applying a bunch of band-aids, I've decided...

> it changes the angles of hitobjects when they shouldn't need to be changed Angles need to be changed aggressively to avoid objects clumping together in a corner of the...

> allowing sliders to move but not rotate themelves off of their original angles , especially in grid maps Slider rotation was added to increase playability because there were often...

This is related to https://github.com/ppy/osu/pull/16771. The virtual audio mixer would allow the whole `IApplicableToTrackMixer` interface to be removed. Instead, the audio mixer will be provided to mods via `IApplicableToTrack.ApplyToTrack(Track, IAudioMixer)`....

Here's how https://github.com/ppy/osu/pull/16771 can be changed to make use of the virtual mixer: https://github.com/ppy/osu/commit/c500bccd2e9408359c2183b2fd0be2bd4b461dda Full diff with master (along with basic usage of the provided audio mixer in muted mod):...

Did not realize that global and local mixers are completely separate. I don't think it's a good idea to juggle with 2 track mixers then, at least not before #4915...