Henrik Lissner

Perhaps more keys could be added to `evil-magit-popup-changes` upstream? In the meantime, this could be done for p and P with: ```elisp (after! evil-magit (evil-magit-change-popup-key 'magit-dispatch "P" "p" 'magit-push)) ```

As of 9e6c46a this should finally be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

I have a maintenance fork at https://github.com/doomelpa/code-review, where I merge any promising PRs I find here, but I don't actively develop it, and this issue is not resolved there either....

Please check [the \*Messages\* buffer](https://discourse.doomemacs.org/t/how-to-debug-issues/55) for errors at startup. Keybindings are often the first casualty to startup errors. If you find an error, please produce [a backtrace](https://discourse.doomemacs.org/t/what-is-a-backtrace-how-to-produce-them/85) from it as...

I notice that the order of modules is different when you use `doom sync`, which can easily cause your issue, but I can't reproduce it. Is your config up somewhere...

It seems it's `doom install` that gets the module list backwards. I notice you have `:config default` very high in your `doom!`. Order matters for the `:config` and `:app` groups...

Try this: ```elisp ;;; add to $DOOMDIR/config.el (after! persp-mode (remove-hook 'persp-filter-save-buffers-functions #'+workspaces-remote-buffer-p)) ``` This will prevent persp-mode from filtering out remote buffers. Fair warning though, this could slow down session...

Thanks for the PR, but I must turn it down. I plan to move rainbow-delimiters out of core soon, and I haven't yet decided what to do with it (or...

Can you list a few (or more) example buffers that'd benefit from this? It may still be desirable to capture some and not others, so I can't approve of this...

Since there are legitimate mu4e buffers we want to treat as popups (like `*mu4e-log*` and possibly some of the attachment preview buffers), I must turn down this PR. More nuanced...