doomemacs icon indicating copy to clipboard operation
doomemacs copied to clipboard

fix(mu4e): extend popup rule to all mu4e- prefixed buffers

Open seanfarley opened this issue 1 year ago • 2 comments

It was too restrictive before so let's just match anything that is prefixed with mu4e-.

seanfarley avatar Mar 12 '24 17:03 seanfarley

Can you list a few (or more) example buffers that'd benefit from this? It may still be desirable to capture some and not others, so I can't approve of this PR if there isn't a more specific benefit.

hlissner avatar Mar 13 '24 00:03 hlissner

Ah, yeah, that's a good point. The previous logic didn't consider composing both a reply and a new message, so sometimes the reply would pop up in a really tiny window. I'm actually really curious if this is the correct way or not because I don't really understand the display-alist stuff.

seanfarley avatar Mar 13 '24 03:03 seanfarley

Since there are legitimate mu4e buffers we want to treat as popups (like *mu4e-log* and possibly some of the attachment preview buffers), I must turn down this PR. More nuanced popup rules are needed for this module, in any case. Thanks for bringing it to my attention though!

hlissner avatar Sep 11 '24 08:09 hlissner