Hugo Landau

Results 328 comments of Hugo Landau

@nhorman So, this is a nice idea, but won't quite work. There are various reasons, but here's an arbitrary one: ``` T1 calls some blocking API call, and enters block_until_pred...

Merged to master. Thanks for the reviews.

Does that mean if we drop the atexit call, we could argue it isn't a breaking change? We should be calling OPENSSL_cleanup in our own unit tests for valgrind etc.

This appears to be a bug. Thanks for reporting it. Fix is in https://github.com/openssl/openssl/pull/23567 and should be in 3.2.2.

It would depend on Python. You can set `OSSL_RUN_CI_TESTS` to run it locally.

> > It would depend on Python. > > Then perhaps it should actually depend on if python is available or not. The module `IPC::Cmd` has a functions `can_run` for...

This is now working. Artifacts: https://github.com/openssl/openssl/actions/runs/7871749345?pr=23551

I've moved some of the artifacts upload code out of the unit test recipe. The QLOGDIR code should definitely remain in the recipe; test-runs is exactly where this data is...