Nam Le

Results 45 comments of Nam Le

> > That's fine. Are you, @ColinKerr, or anyone else looking more generally into the quantity formatting and units APIs? They've been stuck in alpha/beta for years, people have been...

Fixes https://github.com/iTwin/itwinjs-backlog/issues/1116

Few bugs: - The edit custom layer / add new custom layer modal only lets you type in one character at a time, with the input field unfocusing after every...

Closing this, as of today, map layers v6 has been officially released, latest version is `6.0.7`

@mathieu-fournier We can add logic into the measureDistanceTool to add a line for `Bearing`. By default, it will try to get a format associated with the KoQ [`RoadRailUnits.Bearing`](https://github.com/iTwin/bis-schemas/blob/a9f405ad030fe808c3890c60c8a88adf391cece3/Domains/2-DisciplinePhysical/Civil/RoadRailUnits/RoadRailUnits.ecschema.xml#L23) through the...

I'll also add that the persistenceUnit this measurement will look to use is unit.HORIZONTAL_DIR_RAD, not unit.RAD like the schema for RoadRailUnits shows in the link for the comment above. Since...

Understood. Implementation-specifics for this task will involve editing `DistanceMeasurement` [getDataForMeasurementWidgetInternal()](https://github.com/iTwin/viewer-components-react/blob/ccbdce4d4594d1e50906f421b5180c043c84875b/packages/itwin/measure-tools/src/measurements/DistanceMeasurement.ts#L471-L501) to calculate the bearing, apply a bearing FormatterSpec to generate a formatted string, and push an entry to the returned...

![Image](https://github.com/user-attachments/assets/23c018fc-6905-4c01-aaf8-321956b2105c) @mathieu-fournier is this a correct bearing value? I calculated the bearing in this [code snippet](https://github.com/iTwin/viewer-components-react/pull/1336/files#diff-d0b21a1bea2aaf8f9c4133a0e4cc6c3d72c124e07fded3206e3efae28639a68cR518-R519) of a WIP draft PR

Oops, the code used absolute values for dx and dy, so it was buggy. After fixing it, it works in all 4 quadrants ![Image](https://github.com/user-attachments/assets/db693d8e-37a4-4023-b805-a72000dab94b) ![Image](https://github.com/user-attachments/assets/2828b0a2-6a49-4bf6-90fa-5c2e48ce1de5) ![Image](https://github.com/user-attachments/assets/566f194d-894f-41c6-9bdd-11fd6f8ea32d) ![Image](https://github.com/user-attachments/assets/2784cb0b-6c2f-4546-99e4-e2db7384a4c2) I couldn't draw...

Every package has multiple high vulnerabilities, I would suggest tackling each package's vulns in its own separate PR...