viewer-components-react icon indicating copy to clipboard operation
viewer-components-react copied to clipboard

map-layer v6 release todos

Open hl662 opened this issue 1 year ago • 6 comments

Following the merge of this PR, ~we still have some usage of deprecated appui APIs that would take a more focused effort to remove.~. Removed deprecated via this PR. Once we address sub-issue attached, we can reliably move map-layers to v6.0.0.

Here are the list of things left:

Tasks

  • [x] Replace usage of ImageCheckbox in SubLayersTree component.
  • [x] Replace ResizableContainerObserver, either by dropping it entirely or resorting to third party libraries.
  • [x] Address replacing NumberSelect with iTwinUI Select, with more custom handling to fit previous NumberSelect functionality
  • [x] Replace usage of core-react Popup with iTwinUI Popover. Adjacent matter, useOnOutsideClick is deprecated, custom handling of outside clicks for these components have to be added
  • [x] replace all deprecated code
  • [x] The map manager settings popover has some inside elements going outside the bounds of the popover, make sure the parent element wraps the other one
  • [x] https://github.com/iTwin/viewer-components-react/issues/1188

hl662 avatar Jan 29 '25 21:01 hl662

Issues with popups that need to be resolved:

  • transparency slider Image

  • add layer popup for backgrounds and overlays Image

  • attach map layer for backgrounds and overlays Image

I think moving to iTwinUI completely should help resolve this, need to remove all usage from itwin/core-react

aruniverse avatar Jan 30 '25 18:01 aruniverse

[email protected] has been released with some new fixes (https://github.com/iTwin/viewer-components-react/commit/6efc511ae3d8b99c0980255556bd6f930b1113a0)

aruniverse avatar Feb 12 '25 15:02 aruniverse

Few bugs:

  • The edit custom layer / add new custom layer modal only lets you type in one character at a time, with the input field unfocusing after every type.
  • Same issue above with the add custom query parameter modal.
  • The sublayer popover could have the search bar shifted a bit to the right more

Image

  • The map manager settings popover has some inside elements going outside the bounds of the popover, we want to make sure the parent element wraps the other one

hl662 avatar Feb 12 '25 17:02 hl662

Few bugs:

  • The edit custom layer / add new custom layer modal only lets you type in one character at a time, with the input field unfocusing after every type.
  • Same issue above with the add custom query parameter modal.
  • The sublayer popover could have the search bar shifted a bit to the right more

Image

  • The map manager settings popover has some inside elements going outside the bounds of the popover, we want to make sure the parent element wraps the other one

Issues resolved with this PR

pachhaibipin avatar Feb 20 '25 16:02 pachhaibipin

Is this issue closed?

rbreukelaar avatar Mar 19 '25 01:03 rbreukelaar

Is this issue closed?

there are some pending items we'd like to include before the official 6.0 release of map-layers such as supporting google maps and itwinjs 5.0. we will be adding to this list as we get more clarification on direction of map-layers

aruniverse avatar Mar 19 '25 01:03 aruniverse

Closing this, as of today, map layers v6 has been officially released, latest version is 6.0.7

hl662 avatar Sep 24 '25 18:09 hl662