hkwak

Results 6 issues of hkwak

fix the html code in the code example

1 comment

Should not the quoteString method be public

4 comment

https://github.com/cakephp/phinx/blob/877033d6e44d60f8ff149fa9f57f135a33fbbff6/src/Phinx/Db/Adapter/PdoAdapter.php#L283 Currently the quoteString method exists, but it is protected, making it impossible to use in migrations. Is there anything what stops it being public?

enhancement

getAccessToken fails when refreshing a token

1 comment

The \OpenIDConnectClient\OpenIDConnectProvider::getAccessToken method is not only used for exchanging the initial token, but also for obtaining the Refresh Token. When refreshing a token, there is no ID Token included, as...

do not process id token on token_refresh grant

Allows refresh_token grant without ID Token processing

remove final

Any chance to remove final from OpenIDConnectProvider? It would allow people to override some methods for extra logging in subclasses

short opening php tag in default.config.php

The short opening php tag is causing issues if not allowed in php configuration as it is very easy to leave unnoticed. All other files use full opening tag