BALM icon indicating copy to clipboard operation
BALM copied to clipboard

issue in fix T0

Open huanglilong opened this issue 1 year ago • 2 comments

https://github.com/hku-mars/BALM/blob/df9a376db9f573b4faf0562c11dcc176b685d18d/src/benchmark/benchmark_virtual.cpp#L467 @Zale-Liu actually, x_stats[0].p and x_stats[j].p in global frame, x_stats[j].R is from body frame to global frame origin code:

x_stats[j].p =
    x_stats[j].p - x_stats[j].R * x_stats[0].R.transpose() * x_stats[0].p;
x_stats[j].R = x_stats[j].R * x_stats[0].R.transpose();

fixed code:

x_stats[j].p = x_stats[0].R.transpose() *(x_stats[j].p - x_stats[0].p);
x_stats[j].R = x_stats[0].R.transpose() * x_stats[j].R;

huanglilong avatar Jan 11 '23 11:01 huanglilong

thanks for great works! @Zale-Liu initial pointcloud in global frame with noise poses: image optimized pointcloud in global frame with optimized poses: image

huanglilong avatar Jan 12 '23 06:01 huanglilong

Yes, you are right. It is a bug I forget to fix.

Zale-Liu avatar Jan 14 '23 08:01 Zale-Liu