Hemant Kumar
Hemant Kumar
Hi @bensigelman, thanks for referring to this point. I agree, that a span is not necessarily active even if it hasn't finished. But, the way the perf events are opened...
Hi @bensigelman to add to the above comment, I want to add something more here. There are multiple ways on how we can start a perf event within a span....
As discussed with @bensigelman (please point out if I missed something) on gitter, here is a brief summary : The perfevents are started at the beginning of the span (if...
Yup, seems like a good idea, since observers will be anyway optional. @bhs if you will create a repo (maybe opentracing-contrib/observer?) for this, I will move the PR there.
Thanks @bhs, I have moved the PR to : https://github.com/opentracing-contrib/go-observer/pull/1