Marijn Schouten

Results 30 comments of Marijn Schouten

This is one of the problems fixed by this PR: https://github.com/exercism/rust/pull/1549

This issue is a duplicate of https://github.com/thedodd/trunk/issues/249

This seems like a great change, but I was interested in seeing if any real-world code is broken by this. Where can I find the crater run with this change...

Thanks, that is very helpful. I am porting from 0.4 and trying to follow the migration guides, but I don't recall seeing this information. Anyway, that seems to have been...

> One way to do that would be to add > > ```rust > // in std::num::consts > pub struct Pi; > ``` > > And add `impl From for...

It will probably help if you remove the chmod calls in the script that is called. For example by running: `sed -i -e '/.*chmod.*/d' StarRuler2.sh`

@zooko you should really clean up the commit history and remove temporary debug stuff and merge fixup commits with the commit they fix up. Also separate out all unrelated stuff,...

@orlp does this still hold with `std::hint::blackbox`?

Apparently `offset_from` stabilized in 1.47.0 (35 versions behind 1.82.0 times 6 weeks is 210 weeks or about 4 years old) is too new as MSRV=1.36. It "is equivalent to (self...

MSRV is now 1.47.0, and this patch now passes all checks. There should not be any performance impact, since this only changes a debug_assert.