Heiko Jerichen

Results 12 comments of Heiko Jerichen

I thought about my solution again and I think it is a mistake. In the $sources I use for the PrefetchBuffer there my be unserializable objects, and that would result...

That is too bad. I was hoping one of you active maintainers have more insights on how prefetching is working under the hood. In the case of prefetchPosts `$sources` are...

@oojacoboo maybe I have expressed myself incorrectly. If you have a look to the method computeHash ```php private function computeHash(array $arguments): string { return md5(serialize($arguments)); } ``` After my change...

My reasoning here is that registering a new object to the prefetch buffer (for instance a Blog type object) should invalidate the corresponding result cache.

If you agree with me here, I will add more unit tests to the PrefetchBufferTest class.

Assume that you want to query a list of posts and each post as several comments. The `PrefetchBuffer::register` method is called for each post. Lets assume the hash key is...

Yes. In $this->results are the comments for the posts in $this->objects.

@oojacoboo Did you have time to take a look at it? Would be great to have this fixed.

Maybe an other example: ```gql query { managers { id addresses { id street } purchasers { id addresses { id street } } } } ``` Lets say purchasers...

How about using the internal IDs of the objects to create a Hash?