mqtt-cli icon indicating copy to clipboard operation
mqtt-cli copied to clipboard

Update publish.md

Open WeMakeMachines opened this issue 3 years ago • 5 comments

Motivation

Remove documentation inaccuracies

Changes

Fixed some mqtt pub references --> documentation referred to topic "topic" when the example command clearly shows the topic "test"

WeMakeMachines avatar Jun 01 '22 15:06 WeMakeMachines

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @WeMakeMachines on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] avatar Jun 01 '22 15:06 cla-bot[bot]

Hi @WeMakeMachines,

Thank you for your contribution and handing in your CLA. I will redo the CLA check and someone else from the team will take care of your PR soon.

Have a nice day!

Magi

@cla-bot check

MagiErber avatar Jun 01 '22 15:06 MagiErber

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jun 01 '22 15:06 cla-bot[bot]

I noticed in the CONTRIBUTING.md file, I should open a PR targetting the develop branch, but it seems this repo does not have a develop branch. If you can suggest a different branch to merge to, I will change my PR. What I'm proposing here is only a minor change; and probably would just as easily go by unnoticed, but nevertheless I think it useful to have accurate examples.

WeMakeMachines avatar Jun 01 '22 16:06 WeMakeMachines

Hi @WeMakeMachines, the process changed and the CONTRIBUTING.md is outdated. Currently, merging the PR into master is the way to go.

gitseti avatar Jun 10 '22 08:06 gitseti