hius07
hius07
I cannot reproduce. I switch several books via History, open their notebook files with a gesture (creating, editing, saving, not saving, whatever in Text editor), and each book opens its...
Hope this helps.
Yes, tomorrow morning.
https://github.com/koreader/koreader/blob/fa4654cdfa56e7452f6e6ae43d19cd65c105401c/frontend/ui/data/creoptions.lua#L382 https://github.com/koreader/koreader/blob/fa4654cdfa56e7452f6e6ae43d19cd65c105401c/defaults.lua#L141
Dispatcher does not read the user's "defaults", it shows the default "defaults", it's okay. Dispatcher does not pass "units" to SpinWidgets (so you do not see the % sign), it...
> Overall, I believe these DEFAULT_SETTINGS are legacy from `crengine` and they should be de-duplicated. Where do you propose to store the settings for the first run, after clean install?
@yparitcher, do you think we should introduce `G_reader_settings` in Dispatcher? (Just for the user's default values in SpinWidgets - font size, line spacing etc)
Generally speaking, I would remove "default value" from all SpinWidgets in Dispatcher (i.e. Gestures/Profiles action list). For the consistency reason: there are many other actions that have their default values...
But what definitely must be fixed: consistent min/max values and units in SpinWidgets in theDispatcher and in the ConfigDialog (bottom menu).
Is there anything to fix?