hius07
hius07
Doesn't crash but fails. Maybe some recent changes of JSON by @pazos.
Saving just one tap?
If an item is added to the menu, it would be good to add an action to Dispatcher. Inconsistent behaviour of the Return (bottom left) button, depending on previous opening...
Similar to https://github.com/koreader/koreader/issues/13176.
You didn't mention the target language.
As I recall, this change was done to fix a non-critical issue: some plugins (MoveToArchive? do not remember exactly) passed to ReaderUI shortened filepath, ie `.\book\book.epub` instead of `\mnt\us\koreader\book\book.epub`. Symbolic...
The line removed in https://github.com/koreader/koreader/pull/12902.
> Any better name or place to put those strings? Can it be in the PluginLoader? (some appropriate code changes required)
I mean this chunk https://github.com/koreader/koreader/blob/ce7fcff3608cd3f4ee24898b82a3c2e680f202c3/frontend/pluginloader.lua#L17-L26 A plugin would pass a key (remove/feature) and a string. PluginLoader would add one of these new strings, depending on the key.
Looks good, thanks.