hius07

Results 641 comments of hius07

Total number of pages is 170. flow[0]=={1,165}, flow[1]=={1,5} Looks like flow0 is incorrect.

> Regarding the suggested fix, it feels `self:getFirstPageInFlow(0)` should be fixed to return the right value - without kludge in upper users like getNextPage(). > But `self:getFirstPageInFlow(0)` just return `self.flows[0][1]`,...

Besides, I noticed that even when I restarted the regular flow from page 1 (no hidden flows at all), I still have in the book metadata.lua: ``` ["handmade_flow_points"] = {...

Will be fixed in https://github.com/koreader/koreader/pull/13018 (except the Home icon help text).

If they are drawn in the order, this should be inserted before `item_tmp`: https://github.com/koreader/koreader/blob/8297d17e54374fcb568e14b03a3a9ca94aac577e/frontend/ui/widget/touchmenu.lua#L715 But the `_underline_container` of unfocused items may overlap the line in that case.

Upper menu is a TouchMenu widget.

> need to find what top menu's widget is doing to "focus on disabled items" https://github.com/koreader/koreader/blob/921dde0b31dd17fdf4dd4ecbde7260ce2319d443/frontend/ui/widget/touchmenu.lua#L710-L712

https://github.com/koreader/koreader/blob/921dde0b31dd17fdf4dd4ecbde7260ce2319d443/frontend/ui/widget/inputdialog.lua#L506

Try it ```diff --- a/inputdialog.lua +++ b/inputdialog.lua @@ -503,7 +503,9 @@ function InputDialog:reinit() end function InputDialog:addWidget(widget, re_init) - table.insert(self.layout, #self.layout, {widget}) + if widget.enabled then + table.insert(self.layout, #self.layout, {widget}) +...

Right, not so simple, we must add/remove it every time in https://github.com/koreader/koreader/blob/8297d17e54374fcb568e14b03a3a9ca94aac577e/frontend/ui/widget/openwithdialog.lua#L34-L45 And to find out whether a widget is in self.layout we need its id (a new property).