Tabby

Tabby copied to clipboard

In `MainActivity`, `CustomTabActivityHelper.mayLaunchUrl` can't be called during `onCreate`: neither the client or session are created because their creation happens after `onCustomTabsServiceConnected` callback, which is called in `onStart`. The `CustomTabsSession.mayLaunchUrl` optimization...

ekchang

PendingIntent not overridden

4

https://github.com/hitherejoe/Tabby/blob/master/app/src/main/java/com/hitherejoe/tabby/ui/activity/MainActivity.java#L184 and https://github.com/hitherejoe/Tabby/blob/master/app/src/main/java/com/hitherejoe/tabby/ui/activity/MainActivity.java#L177 You should use the `PendingIntent.FLAG_UPDATE_CURRENT` flag. It's not really useful in your case as you always open the same Url. But if someone is using this code...

PomepuyN