PendingIntent not overridden

[PomepuyN]

https://github.com/hitherejoe/Tabby/blob/master/app/src/main/java/com/hitherejoe/tabby/ui/activity/MainActivity.java#L184

and

https://github.com/hitherejoe/Tabby/blob/master/app/src/main/java/com/hitherejoe/tabby/ui/activity/MainActivity.java#L177

You should use the PendingIntent.FLAG_UPDATE_CURRENT flag. It's not really useful in your case as you always open the same Url. But if someone is using this code for multiple websites, the PendingIntentwon't be overridden and the share / email will be performed on the first opened website.

[LiJunyang]

HI, I run the demo ,and the share and the email item did not show in the topbar,why?

[hitherejoe]

Ah yes that is true, thanks for pointing that out @PomepuyN - I'll stick it in :+1:

[hitherejoe]

@LiJunyang if you don't have a version of chrome that supports custom tabs then it's probably launching in the standard browser

[LiJunyang]

thanks