hishitetsu

Results 98 comments of hishitetsu

Actions should be stateless. In other words, they shouldn't have any fields which change the process depending on the value. Control of processing should always be by reference to external...

> You are telling that there’s no guarantee of GetIsExecutable being called at all right? Yes. > Why the actions should be stateless? More precisely, actions may refer to external...

* Your PR appends the number after the file extension, but it should be appended before the file extension. * If you want to match the behavior with Explorer, the...

> I was thinking whether I should declare a variable or directly call the function? My only deciding factor was declaring variable in this case makes it more easy to...

> Oh no no I was saying about var fileName. There is no problem as it is 👍

@ashrafmansuri there are lines with extra spaces, please remove them if you have time. ![image](https://github.com/files-community/Files/assets/66369541/4c328cb4-d131-427e-b6f8-29fa9d368ff6)

KeyDown will make the selection, but only to the middle of the text box, not to the beginning or end of the text box in case of Grid/Tiles/List view. Also,...

As far as I have tried, thumbnails are reloaded after zooming in/out without disappearing. https://github.com/files-community/Files/assets/66369541/7e7662a4-27a7-4266-b0b2-6df320a8ee5d

I think the blanks are not because the thumbnails are reloading, but because the entire page is taking a long time to display. I mean, it goes like this: Thumbnail...