Hisham Muhammad
Hisham Muhammad
@nicolasnoble Thank you for the PR! Left you a review comment.
@HamzaMateen yes, you can! This is still an active bug. It's a good way to start getting acquainted with the Teal parser.
Oh, I thought it already parsed those things, since it does a good job on detecting when arguments documented don't match the code. I see the difficulty then.
@jclavier44 thanks for catching this! The `mode` argument should be of type `io.OpenMode` there. A PR correcting the example, and any other missing/incorrect instructions from the examples README, would be...
Can you reproduce this with types other than nil? Teal does not support discriminating nil in unions, so you cannot implement nil-strictness by hand, it will need to be added...
I've confirmed this misbehavior with a non-nil-related minimized example ```lua local type Maybe = T | boolean local x: Maybe if not x is boolean then print("Result: "..x) end ```
Note to self: the solution to this bug is that union types need to be handled as generic types the same way as functions and records currently are — that...
Teal in general is pretty lax with bivariant function matching, so if we're going with bivariance for functions everywhere, then yes, ideally this should be accepted. (With the caveat of...
...and this is a little trickier because generally we've been stricter about _redeclarations_ of record functions. Which is, in general a good thing, because a function implementation not matching its...
PRs welcome! But would that require a rockspec_format version 4.0, though?