hirochachacha

Results 28 comments of hirochachacha

Thanks, give me some time to review and think. I will revisit this on this weekend.

Hi, sorry for the delay. I did some investigation and I concluded that current `Security/SetSecurity` design doesn't work well because sacl and dacl require different permissions. Instead, I want to...

Sorry for the late reply. I'm still unsure of the right approach here. Because I want to provide hight-level abstraction in this library, I don't want to reveal whole low-level...

I don't know how to detect OS in smb2. I just googled it, and it seems to me that nmap currently doesn't support OS detection in smb2. It has `get_os`...

really? I can't see any os information on wireshark. ![image](https://user-images.githubusercontent.com/898442/119214439-d2260300-bb01-11eb-901e-d024846f7a83.png)

As far as I can tell, that's is more like NTLM version. We can't detect os itself like linux, macos because there're no constants for third party's implementations. https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-nlmp/b1a6ceb2-f8ad-462b-b5af-f18527c48175 https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-nlmp/a211d894-21bc-4b8b-86ba-b83d0c167b00#Appendix_A_31...

It works as intended. Each share has its own type. $ suffix means special type. You can filter it out by using `strings.HasSuffix`. See https://docs.microsoft.com/en-us/windows/win32/api/lmshare/ns-lmshare-share_info_1 for detail.

Can you elaborate? Are you saying that `ListSharenames` should return `(ShareType, string, error)` instead of `(string, error)`?

Can you ensure that `smbclient` and your `smb2-share` program connect to same server? share name like `H$` isn't abbreviation of another share name, it's valid share name on windows server....