Trevor Hilton
Trevor Hilton
> I think I prefer alternative 1 as that maps to the API (`/api/v3/query_sql` and `/api/v2/query_influxql`). All the other stuff looks good to me. Although (1.) requires a little more...
I have spent some time reviewing the IOx `query`/`write` sub-commands and have come away with the following: * We will need to implement an `influxdb3_client`, which I have created an...
For querying: after some discussion, we decided to go with a single `query` sub-command, similar to the original proposal above. This provides a single point of access, and allows us...
@mgattozzi - as per PR comment, here are some ideas I had re: the `token` CLI. I didn't want to block the PR with them, so we could pursue them...
> I suggest `influxdb3 ` (in this case, `influxdb3 token create`) Agreed, this works better if there are resource specific actions that go beyond basic CRUD, e.g., `influxdb3 token disable`....
[`config-rs`](https://crates.io/crates/config) is good as well if we want support for file formats like TOML, YAML, etc. - but I don't know how well that plays with `clap`, and may not...
@mgattozzi - I pulled down `main` and merged into this branch in [fe7aa53](https://github.com/influxdata/influxdb/pull/24671/commits/fe7aa5394228dfe5e62038a14f72b0887439922a) and also did the clippy thing.
Hey @mechiru, understood. Thanks for the quick response and suggestions. I've spent some time reading through the code here and see that this wouldn't necessarily be a trivial change, e.g.,...