Michel Hidalgo comments

Results 335 comments of


                                            Michel Hidalgo

rcl_wait() returns early when a timer awakes

This one's still causing regressions (I think): https://ci.ros2.org/view/nightly/job/nightly_win_rel/lastCompletedBuild/testReport/projectroot/test/test_timer__rmw_connextdds/

Parse parameter descriptors in yaml

@bpwilcox are you planning to circle back on this?

Parse parameter descriptors in yaml

@bpwilcox do you still plan on submitting changes? Or shall I close this patch?

Parse parameter descriptors in yaml

@bpwilcox friendly ping

Error handling often overwrites errors already set

IMO our main issue here is that there's no clear path forward. Even if we decide to rely on all libraries sharing the same error handling state, `rcutils` error handling...

Error handling often overwrites errors already set

FYI @Blast545 @brawner.

Error handling often overwrites errors already set

> Thought a little on this, what if a "build" flag is set then the overwritten errors are print to stderr and if not set the error is overwritten without...

Error handling often overwrites errors already set

That's one way forward, but I will point out that: - Propagating error states with the current API is clunky. Namely, chaining error states properly is hard, and we don't...

Error handling often overwrites errors already set

> Chunkiness can be fixed with a better API. Sure. I was just stating that if we go that way we probably have to roll out new API. > Is...

Error handling often overwrites errors already set

> I don't get this point, my suggestion was to not build backtraces but to handle existing errors properly, only combining their message text, as needed, into a single error...