Michel Hidalgo

Results 335 comments of Michel Hidalgo

Pending on https://github.com/gazebosim/gz-common/pull/460.

Re-targeting to Garden.

@osrf-jenkins retest this please

Hmm, was that a bot or did we actually re-triggered CI at roughly same time @nkoenig ?

@osrf-jenkins run tests

We have some failures on Jenkins: - https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/9791 fails a bunch of tests, seemingly unrelated to this patch. - https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/9405 fails the build with `#include nested too deeply`. I suspect...

See https://github.com/gazebosim/gz-common/pull/471.

Let's try again: @osrf-jenkins run tests

@caguero @nkoenig the integration test is failing on Windows CI with: ``` 99: [Err] [C:\Jenkins\workspace\ign_gazebo-pr-win\ws\gz-sim\src\SystemLoader.cc:103] Failed to load system plugin: (Reason: Could not find shared library) 99: - Requested plugin...

Alright, CI is finally mostly green. Test failures on Windows are unrelated. @arjo129 @caguero may I ask you to do a final review?