Michel Hidalgo
Michel Hidalgo
> The active test before calling proc_info.assertWaitForShutdown(process=executable_under_test, timeout=10)? Or do I have to add an extra executable to my launch description that does this? Any of the two would work.
cc @ivanpauno @wjwwood
Many actions make use of the `os` and `os.path` modules, and IIRC Python does not offer "universal paths" like it does for "universal newlines". Or I don't follow why `pathlib`...
The spirit of this ticket was to enable a user to use POSIX paths throughout launch files and make that portable across platforms. To my surprise, in many cases you...
+1 to using `pathlib` . @caioaamaral a contribution would be most welcome!
@ivanpauno I'd be inclined to use a single colon `:` instead of two `::` to be consistent with [XML namespaces syntax](https://en.wikipedia.org/wiki/XML_namespace). Also, I'd make the operator markup-language dependent e.g. using...
I fully agree @MarcoLm993. Would you be willing to contribute a patch?
> I'd like to contribute in any way possible, although I just have user level experience with the new launch system. @v-lopez That's great! I'll forewarn you that this isn't...
> Loggers are designed to be predictably named and long-lived. We should not be creating 3 different loggers PER SUBPROCESS NAME. Instead we should probably be using one logger named...
> What are these logging needs? Do they consist of having more than one logger per subprocess stream? In the most general case, different log formats and sinks for each...