qupeng comments

Results 75 comments of


                                            qupeng

redo manager should only clean files of one specified changefeed instead of all changefeeds

/severity major /remove-label question

redo manager should only clean files of one specified changefeed instead of all changefeeds

/remove-label may-affects-4.0 /remove-label may-affects-5.0 /remove-label may-affects-5.1 /remove-label may-affects-5.2 /remove-label may-affects-5.3 /remove-label may-affects-5.4 /remove-label may-affects-6.0 /remove-label may-affects-6.2

0.1: deadlock when poll mpsc::Receiver and mpsc::Sender in one thread

I'm trying to reproduce it in futures 0.3. But seems `struct Spawn` and `poll_future_notify` are not in futures 0.3? Any other things to replace them?

0.1: deadlock when poll mpsc::Receiver and mpsc::Sender in one thread

PTAL @Nemo157 thanks!

the invisible mvcc versions are not purged by gc

@shaoxiqian thanks for your report! In the current implementation, MVCC-deletions can only be handled at the bottlemost level. https://github.com/tikv/tikv/pull/10545 may be helpful for this case, we will continue on it.

cdc: load old value from data CF if necessary

/release

cdc: load old value from data CF if necessary

This PR can be closed because fetching old-values in transaction layer increases transactin latency. It's inacceptable. However, the issue could still exist for the cases with very heavy insert load,...

enhance compaction filter context

I have signed the CLA after the checker reported a failure. Anyone can help me to rerun it?

cdc: re-design delegate and downstream to support partial region subscription better

/test

CDC resolved ts stucks, CDC incremental scan encountered lots of RegionNotFound error

It's expected. TiCDC is blocked with some reasons, and TiKV reports this error ``` [ERROR] [endpoint.rs:864] ["cdc initialize fail: Sink send error Congested"] ``` then TiKV will report a `RegionNotFound`...