tiflow
tiflow copied to clipboard
pingcap
redo manager should only clean files of one specified changefeed instead of all changefeeds
Before asking a question, make sure you have
- [X] Searched existing Stack Overflow questions
- [X] Googled your question
- [X] Searched open and closed GitHub issues
- [X] Read the documentation
What is your question?
Test shows there is a bug about cleaning redo-log files when removing a changefeed:
- when removing a changefeed,
managerImpl.Cleanupwill be called; - then
LogWriter.DeleteAllLogswill be called, and all files in the redo-log directory and S3 path will be deleted; - so if several changefeeds share one redo-log directory or S3 bucket, their redo files will be deleted incorrectly.
The bug should effect all versions.
@hicqu: The label(s) effects-6.1 cannot be applied. These labels are supported: duplicate, bug-from-internal-test, bug-from-user, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, question, release-blocker, wontfix, require-LGT1, require-LGT3.
In response to this:
/label effects-6.1 /severity majority /remove-label question
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@hicqu: The label(s) severity/majority cannot be applied, because the repository doesn't have them.
In response to this:
/label affects-6.1 /severity majority /remove-label question
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@hicqu: These labels are not set on the issue: question.
In response to this:
/severity major /remove-label question
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
/remove-label may-affects-4.0 /remove-label may-affects-5.0 /remove-label may-affects-5.1 /remove-label may-affects-5.2 /remove-label may-affects-5.3 /remove-label may-affects-5.4 /remove-label may-affects-6.0 /remove-label may-affects-6.2
