William comments

Results 6 comments of


                                            William

GPSTimestamp::getTime() has time shift in the opposite direction of the system time wrt UTC

I have fixed the issue in my fork by subtracting the timezone in seconds from the returned time_t in line 175 of GPSFix.cpp. return mktime(&t) - timezone;

GPSTimestamp getTime() is Off by One Month

I have fixed this in my local copy by changing line 170 in src/GPSFix.cpp from `t.tm_mon = month;` to `t.tm_mon = month - 1;`.

Implements TryFrom for Deque from array

@newAM, would you be able to review or remove the change request flag as I don't think that this can be merged while that flag is active.

Implements TryFrom for Deque from array

@newAM and @reitermarkus , any chance you can have at look an my replies? @newAM I think your "requested change" flag is still up so this cannot be merged before...

Implements TryFrom for Deque from array

OK. I'm closing this PR and opening a new one.

Use build.rs instead of import!() for matter clusters

I like the `build.rs` approach, mostly for the fact that users can easily navigate the generated code. However, we should avoid having the `generated/` path checked in git. This is...