Hiroshi Ogawa

Results 519 comments of Hiroshi Ogawa

(Sorry to comment on already closed issues) I think I had a potentially same issue when creating a toy unocss plugin of my own. I didn't dig into the detail,...

Interesting idea! Speaking of `--compare` flag, I rememberd this webpack plugin which has a similar idea and compares the bundle stats between the current run and baseline https://github.com/relative-ci/bundle-stats/tree/master/packages/webpack-plugin#bundlestatswebpackpluginoptions It looks...

Assuming that the use case is mostly a local comparison, I made a prototype as a custom reporter: https://stackblitz.com/edit/vitest-dev-vitest-mm6syc?file=vite.config.ts demo ```sh # I used VITEST_BENCH_xxx env var for prototype #...

> We decided to remove the samples from it and introduce a new API to tinybench that allows comparing results with the provided benchmark run without actually running the code....

> If I remember correctly, the reporter already gets the result sorted - so we can't do this in our own reporter because custom reporters would have to reimplement it....

> I expect previous benchmarks to appear in the same table sorted marked like ${name} (previous) or something. I might be still missing something, but let me confirm with my...

It's a rough mockup, but it's possible to create a table like this: ![image](https://github.com/vitest-dev/vitest/assets/4232207/0f738a40-ad5d-473d-bb00-f09d2a9c61ba) @sheremet-va Is the direction okay or did you have something else in your mind?

> is there any way to disable this process when debugging ? I think you can patch `globalThis.console` back to direct stdout writing like this: https://stackblitz.com/edit/vitest-dev-vitest-aff1ys?file=repro.test.ts ```ts import { it,...

Maybe related to this PR? - https://github.com/vitest-dev/vitest/pull/3773 It looks like this PR is introducing "file change -> rerun file change and failed ones"

> is vitest supposed to to always rerun all tests when any test file changes? @waynebloss Vitest is not supposed to do this as explained in https://github.com/vitest-dev/vitest/issues/4997#issuecomment-1898077525 This is expected...