Ivan Ho
Ivan Ho
I can cook the pass for this, but my concern is that a constant such as 0xAAAA might yield 16 concats. Should we have some kind of heuristic for this?
I took a look for a little but I think I’d get stuck on far too much to get it running in any reasonable amount of time. Go ahead, @chelini!
I'm quite concerned about the DecomposeExpReduction implementation, as it seems weird to call the greedy Rewriter in the Pass, then receive it as a Builder in AggregatedOpInterface::decomposeOp, only to turn...
@hanhanW I've written the DecomposeAggregatedOps pass and will write tests in a moment but perhaps it should be in another PR?
> Why do we care DiscardableAttrs after decomposition? It seems like you are relying on this to do further transformation, which seems bad? What information do you need to carry...
> If you'd like to discuss more on how to address (2), I am happy to, but I think it is okay to leave some special cases, because some op...
> This seems like it is ready to land. Let me know if you want me to force push this (the errors seem unrelated) Sure, let's ship it.