hhhjort
hhhjort
Just a friendly ping, are you still working on this?
This PR will require that adapters return imp IDs from MakeRequests so that we know what errors go with which Imps. Blocked until a separate PR adds imps to MakeRequests...
Things have been very busy on our end lately. I have managed to give this a quick review, it is looking good so far. Still want to review a bit...
This PR now also has some conflicts with master to resolve.
There are also some merge conflicts now.
In exchange/bidder.go, I would say line 137 maps best to 100 (General) and line 534 to 101 (Timeout). Line 565 is correct as 102 (Invalid response). The infoawarebidder.go errors all...
Oh, sorry, missed that one. 103 seems reasonable for a 503 error code.
I see at least one bug now. consent.go:68 We check bit to flag that the following is a bit field or a range encoding. The IsSet() function does not verify...