Colin Gilgenbach

icon indicating an email [email protected]

icon company Massachusetts Institute of Technology icon location Cambridge, MA

Results 5 comments of Colin Gilgenbach

wrong line numbers when using "flatten"

It looks like the base problem is with serde's `ContentDeserializer`. This is used for a few things, including `#[serde(flatten)]` and untagged enums. Basically, it uses `deserialize_any` on the original deserializer...

Fixed venv detection on windows, added pyvenv.el detection

Looking through the commit history, it's possible this may cause a regression on issue #122. I'll try do some testing and check that that use-case is still supported. I think...

Fails to parse byte-order mark in certain situations

Note also [section 5.2](https://yaml.org/spec/1.2/spec.html#id2771184). >On input, a YAML processor must support the UTF-8 and UTF-16 character encodings. > | | Byte 0 | Byte 1 | Byte 2 | Byte...

Build failed with CGAL 5.5: UserVisitor’ {aka ‘struct priv::Visitor’} has no member named ‘start_filtering_intersections’

I'm running into this too. I believe this is related to this change in the [CGAL 5.5 changelog](https://www.cgal.org/2022/07/15/cgal55/): > Added more functions in the [visitor of the corefinement based methods](https://doc.cgal.org/5.5/Polygon_mesh_processing/classPMPCorefinementVisitor.html)...

Build failed with CGAL 5.5: UserVisitor’ {aka ‘struct priv::Visitor’} has no member named ‘start_filtering_intersections’

Indeed, adding those stubs to [CutSurface.cpp:1174](https://github.com/prusa3d/PrusaSlicer/blob/master/src/libslic3r/CutSurface.cpp#L1173) fixes the problem. To prevent stuff like this, `Visitor` should probably inherit [`Default_visitor`](https://doc.cgal.org/5.5/Polygon_mesh_processing/structCGAL_1_1Polygon__mesh__processing_1_1Corefinement_1_1Default__visitor.html) to get these stubs for free.