Hrushikesh Dolas comments

Results 6 comments of


                                            Hrushikesh Dolas

Memory leak - issue while downloading large files

Hi @parthea, Please check the pull request. I have added "MediaGenBaseDownload" class which will yield fetched chunks in order to keep RAM consumption linear(equal to chunksize), with the backward compatibility.

fix: Memory leak - issue while downloading large files

Sure @parthea

fix: Memory leak - issue while downloading large files

Thanks for the input @aria1991. @parthea - I have added the tests as asked. Thanks.

fix: Memory leak - issue while downloading large files

@parthea could you check the latest comits for tests. Let me know your assessment...

fix: Memory leak - issue while downloading large files

One of my commit do not have verified tag, causing it to fail CLA check. I will hard reset the commit and update the code with new branch.

Memory leak - issue while downloading large files

One of my commit did not had verified tag, and also causing it to fail CLA check. I will have to create new PR.