Hernan Guardado

Results 15 comments of Hernan Guardado

It's unfortunate I've found your comment so long after you've posted but I think I may have your solution (If you haven't resolved it yet). I believe you're missing the...

Hi @squakez I created a draft PR for this: https://github.com/apache/camel-k/pull/5445 I had a question in the PR regarding how I set a `protobuf` value.

Hi, I'm not sure what value should actually be added for the "protobuf" string in pkg/apis/camel/v1/integration_types.go. The value I gave was `protobuf:"varint,8,opt,name=automountServiceAccountToken"` taking inspiration from other boolean values however the...

@claudio4j Thanks I found the right values. Also I noticed in `pkg/apis/camel/v1/integration_types.go` it has some outdated make goal. To get the right functionality I ran `make generate` instead. Would it...

I added the test to ensure that the field is set properly on the deployment. I also relayed with my security team and it we only need this field so...

Hi @squakez we've been doing some additional testing with 2.3.1 and have noticed there are some other traits that are not working as expected. At the moment looks like Knative-service,...

I need to update the documentation for the syntax on the trait still unless you have any concerns with the approach and I should change it. @squakez

Made the changes so that logic is contained mostly within the mount trait. Parsing is kept to a minimum and I'd just need to update the syntax documentation if the...

@squakez I've run `make generate` to handle the documentation update but there are a lot of additional changes that result from this change, specifically to the CRD definitions. They updates...

@squakez I'm sorry about the delay. I will get this updated and ready as soon as I can.