Hermet Park

Results 592 comments of Hermet Park

> I wonder if ThorVG can cast that specific property to an integer. Would that be okay ? @theashraf If the Lottie data (JSON) violates the spec, it must be...

> when I tried to load the data one problem was a crash - solved [here](https://github.com/thorvg/thorvg/pull/2392) @mgrudzinska This is not the issue point. Strings are expected to end with `\0`....

@ > > > I wonder if ThorVG can cast that specific property to an integer. Would that be okay ? > > > > > > @theashraf If the...

@theashraf The fix will be applied in version 0.14.1. Please note that incompatible type values could be ignored (set to 0).

see also: https://github.com/thorvg/thorvg/issues/1643

@mgrudzinska please assign yourself when you start the task.

This might become a bit of an issue. Hiding issue by an engine side wouldn't be a good solution if there is a spec error, the usage must be corrected...

You don't need to modify getInt() behavior. parser could call the getFloat() instead of getInt() if the data requires the float type.

> @hermet am I allowed to introduce getNum() and inside decide which one to call: getInt or getFloat? or you mean that I should take care about this specific json...

Let's replace with this: https://github.com/thorvg/thorvg/pull/2507