Henrique Vicente
Henrique Vicente
- Remove the hooks from the configuration file and put it somewhere else - Version the changes on the hooks and, maybe, configuration - Change format from JSON to something...
1. An error is not always fatal. Fatal error are better handled by an exception mechanism. 2. Errors and warnings must be sent to stderr instead of stdout. Easily done...
PS: We better improve the merge done by [configs.writeGlobalConfig)](https://github.com/node-gh/gh/blob/f2302d09bcc5ee804641e308879150a0ab039db2/lib/configs.js#L137-L157) before doing so and check everywhere it's being used.
i.e., `gh pr --open --number 21 --number 1` Number is an interative value of the gh pull-request command. The hook structure is broken and gh will crash because the `afterHooksCallback`...
Hi, I'm sending this for the sake of giving back upstream, feel free to use it as you wish. We've created a function to help us use scany more productively...
Example: ``` --- title: "CLI" description: "Check out the latest releases of the WeDeploy" layout: "updates" updates: - version: 1.4.6 date: May 8th, 2018 description: Added support for using custom...
Currently, the TLS information prints after the response header, although it should be printed before the request header.
This isn't affecting me (or I'd send a pull request), but I believe instead of bypassing RemoteAddr if X-Forwarded-For or X-Real-Ip header exists you should test whether RemoteAddr is public....
It'd be nice if node-jira returned the response body as well as the error even for errors as it makes finding bugs on projects that depend on it way easier....
# Description * Add SCRAM SHA-1 and SHA-256 to getParameter command. * Add SASL Supported Mechanisms to hello command. Closes #3778. ## Readiness checklist - [ ] I added/updated unit...