Alice

Results 72 comments of Alice

- Update all uses of `vm.expectRevert()` to specify the selector of the error it should be throwing

- Proper tests for modify position!

- Naming the same - Separate gas tests

Add testing for interactions of NoOp #324 and Access Lock #404 once they are both merged. For example testing a nested call to swap where the inner call NoOps

Test all functions revert without a lock

Remove `vm.assume` and replace with `bound` _or_ actually test the other values revert !

Make a common `SWAP_PARAMS` in Deployers.sol instead of having `IPoolManager.SwapParams({zeroForOne: true, amountSpecified: -100, sqrtPriceLimitX96: SQRT_RATIO_1_2})` copied everywhere

helper functions `_settle` and `_take` could take a uint instead of an int

Hey @nishim3! Just pinging here to get main updated. Otherwise i will do so myself later!

thank you! yes we periodically update the v4-core commit that is used in periphery! hopefully we can get it updated soon but will take a bit of work with the...