v4-periphery
v4-periphery copied to clipboard
[Bug]: Fix BaseHook with latest v4-core update
Describe the bug
After this PR the BaseHook.sol
code no longer matches the IHooks.sol
interface.
Expected Behavior
The params and return data should be updated in BaseHook.sol
To Reproduce
No response
Additional context
No response
Sorry, I wasn't able to create this as a PR, but the changes to make this fix are minimal:
-
beforeAddLiquidity
addsBalanceDelta
param andBalanceDelta
return -
afterAddLiquidity
addsBalanceDelta
return -
beforeSwap
addsint128
return -
afterSwap
addsint128
return
I have confirmed that this works on a local branch
thank you! yes we periodically update the v4-core commit that is used in periphery! hopefully we can get it updated soon but will take a bit of work with the 2 bigger changes that went in today!