Alice
Alice
> Just ran. Not sure how to capture forge snapshot difference in this codebase. We can't yet sadly - we had some issues with CI so had to remove it...
Looks great! Feel free to merge when youre ready :)
Hey @z0r0z ! Really sorry I didnt notice this earlier - we require commits to be signed on this repo for security reasons. Please can you sign your commits 🙏
Its your snapshots commit thats not signed
Hi! Still waiting on: - Signing your old commit that wasnt signed - this will mean pushing new commits to the branch - `yarn snapshots` needs to be run again...
As written by @moodysalem in #132 we could also have a temporary approve method using TSTORE > temporary approve would be a method that uses a transient storage slot to...
Hi @cpppppp7! Having these things in the hook's storage would mean having to SLOAD all of the flags in each transaction. Instead, it just has to reference `address(this)` which is...
Okay i think this is possible in _very_ extreme circumstances. I decided to start experimenting using the numbers on a super low liquidity v3 pool (because low liquidity => tiny...
@marktoda to redo this with invariant tests
Just one natspec suggestion, and please can you merge in main! Then I'll approve and merge :)