Alice
Alice
Thanks for your comments @mugrebot ! The issue was just that the `pools` mapping had moved to a new slot. You can see the storage layout of a contract using...
Thanks so much for making this translation, thats awesome! Someone from our team is going to review it next week 🙌
Feel free to merge if you're happy with it :)
wait before we merge can you fix something else too 😂 the package name should be `v4-core` not `core-next`
Currently protocolFees can be claimed by 2 parties: `owner` and `protocolFeeController` this would only be able to mint balance to 1 of those parties (although approval could be given to...
Sure! Feel free to tag me here if you have any questions!
Hi @abhithory! Your approach in your first comment sounds correct to me! Please feel free to try implementing that as a PR! > what should i set nft is?? currency...
> in "collectProtocolFees" function from where should I subtract the amount?? The amount will be the NFT owner's balance. For that reason we will not need the functions `collect{Protocol,Hook}Fees` anymore....
We have decided not to move ahead with this for now due to the additional cost on swaps for minting a 6909
Please can you run `yarn snapshots` and push the resultant gas snapshots