Henry Tsang

Results 31 issues of Henry Tsang

Summary: Created from CodeHub with https://fburl.com/edit-in-codehub Because a pytorch PR that changes docstrings might break a test that make sure two functions have the same source code. https://github.com/pytorch/pytorch/pull/113260/files We need...

CLA Signed
fb-exported

Summary: Adding a test after enable embedding dim bucketizer diff. Differential Revision: D50483066

CLA Signed
fb-exported

Summary: Adding a unit test for group_tables. This way of testing isn't very reliable, since it just look at how the tables are grouped. Also it relies on ordering of...

CLA Signed
fb-exported

Differential Revision: D49425673

CLA Signed
fb-exported

## ❓ Questions and Help ### Please note that this issue tracker is not a help form and this issue will be closed. Before submitting, please ensure you have gone...

Differential Revision: D56491510

CLA Signed
fb-exported

Differential Revision: D56449813

CLA Signed
fb-exported

Summary: # Problem Problem is once we wrap DP tables with DDP, the parameters are the same, but not synced. So if we reset the parameters in the table without...

CLA Signed
fb-exported

Differential Revision: D55464196

fb-exported
cla signed

# Pyre Bug **Bug description** When using python 3.8 and 3.9 with pyre, getting the following error due to ` code: Optional[int | str] = None` https://github.com/facebook/pyre-check/blob/main/client/language_server/protocol.py#L365 **Reproduction steps** Enter...