Henry Tsang

Results 31 issues of Henry Tsang

Summary: Original commit changeset: 013ae157559e Original Phabricator Diff: D53854369 See Details in https://fb.workplace.com/groups/mbf.users/permalink/1829315864212395/ This is regressing qps in model Reviewed By: zzzwen, henrylhtsang Differential Revision: D54138464

CLA Signed
fb-exported

Summary: Adding numerical equivalence tests for different kernel types. Note that when stochastic rounding = True + is_training = True is always a bit tricky. However, from what FBGEMM team...

CLA Signed
fb-exported

Differential Revision: D53111536

CLA Signed
fb-exported

Differential Revision: D53024751

CLA Signed
fb-exported

Differential Revision: D52841757

CLA Signed
fb-exported

Differential Revision: D52401892

CLA Signed
fb-exported

Summary: Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: D51922412

CLA Signed
fb-exported

Summary: EmbeddingEnumerator.enumerate() is O(N^2) with respect to the number of tables. For large models (5000 tables), this is very noticeable. This diff fixes the N^2 problem by constructing our sharding_options...

CLA Signed
fb-exported

Differential Revision: D51604284

CLA Signed
fb-exported

Differential Revision: D51504888

CLA Signed
fb-exported