Henry Tsang

Results 36 comments of Henry Tsang

@migeed-z not suer if I understand correctly, I thought it got an error since `int | str` is a new syntax for python 3.10 only? And that part `code: Optional[int...

@migeed-z interesting, I tested in https://github.com/pytorch/torchrec/actions/runs/8807458504/job/24174554261 pyre is python 3.8 with "version": "0.0.101703592829", but does not see an error.

@migeed-z I added that code snippet to a single unit test, and then run the pyre github action with it. This one: ``` from typing import * x: Optional[int |...

@stroxler thanks, will explore changing names

Hi, I don't have expertise on dynamic embeddings, so probably will just cc @colin2328 also probably make an issue as well, since it is easier to track there