henryj18
henryj18
On second thought, it is not accurate to say that line of code will not be executed, but still the logic needs to be cleaned up, so that only one...
Perhaps just add an "elif"? So "if ... elif ... else"
> Hey @andreaskoepf and @henryj18, I'm new around here and would like to give this issue a go. I was thinking of implementing some light configuration classes for different model...
Great job! On retrospect, I suggest we streamline the process of opening/managing github issues in the future. We should avoid opening another issue (in this case 1262) just to fix...
More thoughts: if trainer.py will not be changed to handle the default values of config vars, then there are other options, such as filling every .yml file with a complete...
I can take a shot on this issue, and I would like to be part of the solution team of this issue
Perhaps just populate the .yml file with the default values of all the possible parameters, and add some statements in the README.md about the fact that these are the default...
Nice job and kudos to your guys, appreciate your hard work! On retrospect, could we streamline the process by not opening a new issue, but instead placing the people working...