Henry Schreiner

icon indicating a website link iscinumpy.dev icon indicating an email [email protected]

icon company Princeton University icon location Princeton, NJ icon location Particle physicist and software architect working with @iris-hep. @scikit-hep, @pybind, and @scikit-build admin. @pypa member.

Results 2521 comments of Henry Schreiner

replace guide for setup_requires with in-tree backend

Yes, that's right. `get_requires_for_build_sdist` is called when making SDists.

replace guide for setup_requires with in-tree backend

And this is a really interesting idea for scikit-build-core too...

replace guide for setup_requires with in-tree backend

Thanks! This technically does't increase our API footprint (since the use of the these parts of the API were already there), so I think it's fine to merge, though I'm...

replace guide for setup_requires with in-tree backend

No, what I mean is that `build-backend = "scikit_build_core.build"` will do pretty much exactly the recommendation in this PR by default, but would be customizable via `[tool.scikit-build.cmake]` settings.

Consider using to Find Python introduced in cmake 3.12

I've tried at least twice (see old PRs), but FindPython seems to have a bug where you can't fully specify the variables we need. I'll probably work that out, and...

Consider using to Find Python introduced in cmake 3.12

(also, you really need at least 3.15 to use it or 3.18.2 for things like PyPy). But we do provide CMake, and the new backend will be able to smartly...

Error when installing in development mode

Unrelated; I'd be really suprised if you need pybind11 at runtime - it's used to build code only. Unless you really are "JIT"ing code at runtime, but then you are...

tests: add editable test

I would hope this new test fails, and then https://github.com/scikit-build/scikit-build/pull/582 would be required to fix it.

Add hello fortran sample package + tests

I've tried adding the fixes from #494, but this still is broken. "fatal error: no input files"

Add hello fortran sample package + tests

Is it realistic to have no Fortran function? Maybe the first step would be to have a Fortan function, then a second step could solve the functionless case?