Henry Schreiner

Results 2521 comments of Henry Schreiner

Shouldn't this be configurable? You'll waste disk/PyPI space if all symbols are visible, and risk clashes? Though isn't [`_VISIBILITY_PRESET`](https://cmake.org/cmake/help/latest/prop_tgt/LANG_VISIBILITY_PRESET.html#prop_tgt:%3CLANG%3E_VISIBILITY_PRESET) the right thing to use, rather than hard coding it?

Would you like to get something in before #688? I'd like to make a release soon, then merge #688 then #704.

The main reason CMAKE_ARGS support was added was to support conda-forge; it's a disaster if Setuptools supports conda-forge out of the box but scikit-build doesn't. The settings in there are...

> What information is passed on conda-forge via CMAKE_ARGS that was either automatically inferred or unnecessary for setuptools builds I don't remember exactly, see some of the links on https://github.com/scikit-build/scikit-build/issues/588....

`__all__` is from Python, not scikit-build. It is how you tell Python and your reader what is "public" in your module. `__all__` is also used by static analysis tools to...

Why must it be defined? I've already pointed out it's not accessed anywhere in scikit-build's code base, and I'm pretty sure I have never had to add an `__all__` (though...

By the way, https://github.com/henryiii/skbuild-hello-cpp/blob/master/pyproject.toml is an example of such a file.

`setup_requires` is problematic and if you can avoid supporting non PEP 517 builds, you can just delete it, it's deprecated and doesn't really work the way you think. Specifically, if...

If you are careful, yes you can. You just _have_ to list the dependencies in both `setup_requires`, and `install_requires`, and then very carefully design it so that the first run...

The catch-22 is you can't update setuptools this way, that's what prompted PEP 518. You also are stuck with build requirements being installed even when not needed by the final...