Henry Schreiner
Henry Schreiner
Yes, except for the issue with pyproject.fmt not allowing a comment.
I usually only run via `workflow_dispatch` or {github releases|tags} (depending on the project - I like releases, but sometimes tags are needed or better). For main / stable workflows, I'll...
(this is also another reason to use configuration like https://github.com/scikit-hep/boost-histogram/blob/339306d388d7f112afb4e6f619c52ab8252c4f6a/pyproject.toml#L74-L86 instead of putting everything in environment variables)
There are cases were it's more readable to include the default, and safer, in case the default changes. For a standard library example, `encoding="native"` will change to `encoding="utf_8"` in 3.15....
My point is the second one is wrong (and the first check just happens to force you into the second situation and makes it more common). If sysconfig does not...
That's nice, actually; `except:` is a bug that I wish didn't exist. You can always be explicit and suppress BaseException - but that's probably never a good idea. Handling BaseException...
> I don't like this style anyway so this suggestion was not very meaningful. I'm not so used to it as well, but that's probably from exposure to Python
Actual example: ```python try: with open(os.path.join(CMAKE_BUILD_DIR(), "CMakeCache.txt"), encoding="utf-8") as fp: for line in fp: if line.startswith(variable_name): return line.split("=", 1)[-1].strip() except OSError: pass ``` vs. ```python with contextlib.suppress(OSError): with open(os.path.join(CMAKE_BUILD_DIR(), "CMakeCache.txt"),...
FYI, it's fairly easy to make flake8 plugins. See https://github.com/henryiii/flake8-errmsg for a fairly simple (and Python 3.10 pattern matching :) ) example. You don't even need to depend on flake8....
FYI, the 2.1.3 branch (and master) are missing the 3.11 Trove classifier, even though it's tested in CI & wheels are built. It might be a good idea to add...