Henry Schreiner

Results 2513 comments of Henry Schreiner

This code is broken in both 2.9.2 and 2.10.0. If I remove the initialize_interpreter/finalize_interpreter and instead use the scooted_interpreture guard, it works fine in both 2.9.2 and 2.10.0.

Actually I think it's our stuff around FindPython that's breaking, not this one. Will make a new PR just in case I'm wrong and this history is useful.

No, I take that back, this is running the old one - where are these values being set? Not by FindPythonInterp as far as I can tell...

@rwgk or @Skylion007 What do you think? This reverts the 2.10 default change and instead makes it opt-in for now. The problem is that currently tools like scikit-build reuse the...

The now-failing test links to https://foss.heptapod.net/pypy/pypy/-/issues/2444 (CC @mattip), but instead of working, it now seems to be leaking, perhaps? Since this runs on both CPython and PyPY, I'm assuming the...

> Do you know where/how this change happened? https://github.com/pybind/pybind11/pull/2616 points at https://github.com/python/cpython/pull/13362, the implementation of PEP 587.

I think it's there, but it doesn't work. The code path does trigger to set it, but it doesn't do anything.

I'm rerunning it (as part of something else) in #3419 - I'll see if I can see what part is failing.

Interesting, for failure 1, that happens on PyPy3.7 7.3.7 as well (wow that's a lot of threes and sevens). So it's a change with all PyPy, not just the 3.8...